Skip to content

Remove defunct list of Windows installers.#1192

Merged
bhrutledge merged 1 commit intopypa:mainfrom
bhrutledge:fix-linkcheck
Jan 12, 2023
Merged

Remove defunct list of Windows installers.#1192
bhrutledge merged 1 commit intopypa:mainfrom
bhrutledge:fix-linkcheck

Conversation

@bhrutledge
Copy link
Copy Markdown
Contributor

Listed as "Archived" at https://www.cgohlke.com/.

@bhrutledge
Copy link
Copy Markdown
Contributor Author

linkcheck is still failing because http://appimage.org/ is down. Per AppImage/AppImageKit#1229, this will hopefully be fixed, so just removing the link doesn't feel right.

Not sure how to handle this. Personally, I find the requirement of linkcheck to pass for PRs to merge to be cumbersome. It'd be nice if there were a way to only check links added in the PR. @webknjaz @pradyunsg any ideas?

@webknjaz
Copy link
Copy Markdown
Member

That would be a feature request for Sphinx. We could integrate my alls-green action to be able to temporarily allow the link check job to fail.

OTOH, this is solvable by adding it to linkcheck_ignore. It'd be interesting to ignore flaky links for a few days/weeks but not permanently. This could be implemented by checking the current date and extending the list dynamically.

@bhrutledge
Copy link
Copy Markdown
Contributor Author

Well, it's moot for now, since https://appimage.org/ is back up. 😅

We could integrate my alls-green action to be able to temporarily allow the link check job to fail.

@webknjaz Might be nice to do this in a separate PR, just to have it ready when linkcheck fails again.

@bhrutledge bhrutledge merged commit d84c44b into pypa:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants