Skip to content

Add a hashes key to the direct URL data structure#1199

Merged
pradyunsg merged 2 commits intopypa:mainfrom
sbidoul:direct-url-hashes-only-sbi
Jan 30, 2023
Merged

Add a hashes key to the direct URL data structure#1199
pradyunsg merged 2 commits intopypa:mainfrom
sbidoul:direct-url-hashes-only-sbi

Conversation

@sbidoul
Copy link
Copy Markdown
Member

@sbidoul sbidoul commented Jan 29, 2023

Add the hashes key to the Direct URL data structure, as a approved at https://discuss.python.org/t/draft-pep-amendment-to-the-pep-610-direct-url-json-data-structure/22299/4.

@pfmoore

Copy link
Copy Markdown
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

@pradyunsg pradyunsg enabled auto-merge (squash) January 29, 2023 13:35
@sbidoul
Copy link
Copy Markdown
Member Author

sbidoul commented Jan 29, 2023

The linkcheck failure seems unrelated.

@pfmoore pfmoore disabled auto-merge January 29, 2023 14:02
@pfmoore
Copy link
Copy Markdown
Member

pfmoore commented Jan 29, 2023

Apparently I can't merge without all checks passing. @pradyunsg do you know what we do here? (You enabled auto-merge, so I'm assuming you know more about the processes here than me 🙂)

@sbidoul sbidoul force-pushed the direct-url-hashes-only-sbi branch from 32f0a49 to cb7b428 Compare January 29, 2023 15:16
@pradyunsg
Copy link
Copy Markdown
Member

... well, this repo blocks owners from merging PRs that fails CI.

@sbidoul sbidoul force-pushed the direct-url-hashes-only-sbi branch from cb7b428 to be5d8e0 Compare January 29, 2023 22:52
@sbidoul
Copy link
Copy Markdown
Member Author

sbidoul commented Jan 29, 2023

🍏

Copy link
Copy Markdown
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A syntax fix is needed for this to be acceptable.

Comment thread source/specifications/direct-url.rst Outdated
@webknjaz
Copy link
Copy Markdown
Member

do you know what we do here?

@pfmoore we normally fix such things in separate PRs to unblock the CI.

@webknjaz
Copy link
Copy Markdown
Member

The linkcheck failure seems unrelated.

Looking into https://github.com/pypa/packaging.python.org/actions/runs/4037007410, I see that it's been cancelled because of a newer push to this PR:

Canceling since a higher priority waiting request for 'Test-1199' exists

I don't see it being broken. Unless, I'm looking at the wrong log, that is (some tend to be hidden by force-pushes, so it's best to record the exact URLs in the comments for future investigation).
If a job is flaky, restarting it fixes the branch protection too.

@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Jan 30, 2023

Oh, found it: https://github.com/pypa/packaging.python.org/actions/runs/4037021743/jobs/6940079785#step:5:765. So the network was flaky:

(        overview: line  274) broken    https://web.archive.org/web/20190403064038/https://www.paypal-engineering.com/2016/09/07/python-packaging-at-paypal/ - HTTPSConnectionPool(host='web.archive.org', port=443): Max retries exceeded with url: /web/20190403064038/https://www.paypal-engineering.com/2016/09/07/python-packaging-at-paypal/ (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f57c3d9d610>: Failed to establish a new connection: [Errno 110] Connection timed out'))
build finished with problems.

The solution was indeed restarting the job.

@sbidoul sbidoul force-pushed the direct-url-hashes-only-sbi branch 2 times, most recently from cf9127f to fe0a04c Compare January 30, 2023 07:49
@sbidoul sbidoul force-pushed the direct-url-hashes-only-sbi branch from fe0a04c to 2aa2e94 Compare January 30, 2023 07:49
@pradyunsg pradyunsg enabled auto-merge (squash) January 30, 2023 10:12
@pradyunsg pradyunsg merged commit 8d3a552 into pypa:main Jan 30, 2023
@sbidoul sbidoul deleted the direct-url-hashes-only-sbi branch January 30, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants