Use req @ url syntax to install from remote VCS#1207
Conversation
|
This is ready for review. Let me know if you have any questions. 👍 cc @pradyunsg @pfmoore given their involvement in pypa/pip#11617 |
pradyunsg
left a comment
There was a problem hiding this comment.
Could you add whitespace around @? IMO that makes it clearer and easier to read.
* Use 'req @ url' syntax when using pip to install from a remote git repository over 'url#egg=req' to avoid the use of #egg= fragments with a non-PEP 508 name. This will be required in pip v25.0+. - c.f. pypa/pip#11617 for more details.
5f63b8a to
10b0878
Compare
Sure. I applied that universally, rebased, and |
req @ url syntax to install from remote VCS
|
There are issues with sub-directories.
was transformed into
which does not seem correct to me. Is it? |
|
@sinoroc do you have a failing example? @pradyunsg you were BDFL-Delegate for PEP 610 so maybe you can comment more here. |
|
I might be wrong, but I do not think it has anything to do with "PEP 610 – Recording the Direct URL Origin of installed distributions". The issue is that this is not a valid requirement notation for the pip CLI. The best I can find is this section of pip's documentation on "URL fragments" in "VCS Support" which lists two accepted notations for VCS with subdirectory:
|
|
Thanks @sinoroc. Indeed it looks like is what should have been done. I'll open up a fix PR with this correction once I've finished making coffee. |
* Use the correct syntax for url fragments with pip of the form python -m pip install "pkg @ vcs+protocol://repo_url/#subdirectory=pkg_dir" - c.f. https://pip.pypa.io/en/stable/topics/vcs-support/#url-fragments * Revises PR pypa#1207 Co-authored-by: sinoroc <sinoroc.code+git@gmail.com>
* Use the correct syntax for url fragments with pip of the form python -m pip install "pkg @ vcs+protocol://repo_url/#subdirectory=pkg_dir" - c.f. https://pip.pypa.io/en/stable/topics/vcs-support/#url-fragments * Revises PR #1207 Co-authored-by: sinoroc <sinoroc.code+git@gmail.com>
Use 'req @ url' syntax when using pip to install from a remote git repository over 'url#egg=req' to avoid the use of #egg= fragments with a non-PEP 508 name. This will be required in pip v25.0+.
#egg=fragments to valid PEP 508 names pip#11617 for more details.