Skip to content

adding comment and making replace username bigger#661

Merged
di merged 3 commits intopypa:masterfrom
MasonEgger:replace-comment
Oct 28, 2019
Merged

adding comment and making replace username bigger#661
di merged 3 commits intopypa:masterfrom
MasonEgger:replace-comment

Conversation

@MasonEgger
Copy link
Copy Markdown
Contributor

@MasonEgger MasonEgger commented Oct 22, 2019

Added a comment and made the text uppercase to draw attention to it.

Fixes #652.

Copy link
Copy Markdown
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Note that there is several other occurrences of this package name elsewhere in this guide, we should update all of them to match.

@di
Copy link
Copy Markdown
Member

di commented Oct 24, 2019

@Zelgius There's a few other places as well, try searching for example_pkg_your_username. 😉

@di di merged commit b82fe4e into pypa:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

request for "your username" clarification in packaging tutorial

2 participants