Add trove-classifiers to key projects#738
Merged
di merged 2 commits intopypa:masterfrom Jun 4, 2020
arshadrr:add-trove-classifiers
Merged
Add trove-classifiers to key projects#738di merged 2 commits intopypa:masterfrom arshadrr:add-trove-classifiers
di merged 2 commits intopypa:masterfrom
arshadrr:add-trove-classifiers
Conversation
Add a description of the trove-classifiers package to the list of key projects. Closes #714.
di
reviewed
Jun 3, 2020
Member
di
left a comment
di
left a comment
There was a problem hiding this comment.
Some small language tweaks here but otherwise this looks good to me.
Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Contributor
Author
|
Thanks @di |
Member
|
Thanks! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a description of the trove-classifiers package to the list of key projects. Closes #714.
I've made an assumption in writing the description: that readers wont know what classifiers are, and that it wont be immediately obvious(without reading the trove-classfier README) to them why you'd have a package for it instead of using the list of classifiers published on the PyPI. I copied a line off of #714 to explain what a classifier is, and suggested why you'd want to use troves-classifier(its python code, and a repo gets you an issue tracker). Do these make sense?
Any feedback (on style too)?