Packaging Python Projects: Restructure 'A simple project'#894
Merged
Packaging Python Projects: Restructure 'A simple project'#894
Conversation
pradyunsg
reviewed
May 17, 2021
| Creating a test folder | ||
| ---------------------- | ||
| Creating a test directory | ||
| ------------------------- |
Member
There was a problem hiding this comment.
I prefer the original heading, since "Files and folders" is significantly more common phrasing than "Files and directories" IMO.
Contributor
Author
There was a problem hiding this comment.
Appreciated, though "directory" was used more often in this document. After searching around a bit, I think it's also the more accurate term. For example: https://en.wikipedia.org/wiki/Directory_%28computing%29#Folder_metaphor
pradyunsg
approved these changes
May 17, 2021
Member
pradyunsg
left a comment
pradyunsg
left a comment
There was a problem hiding this comment.
LGTM, other than one non-blocking comment.
webknjaz
approved these changes
May 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #866. I shuffled some sentences around and removed some words to make this introduction flow a little better.