Skip to content

Use a PEP517 build front-end in the setuptools guide#898

Merged
jaraco merged 4 commits intopypa:mainfrom
henryiii:patch-4
May 24, 2021
Merged

Use a PEP517 build front-end in the setuptools guide#898
jaraco merged 4 commits intopypa:mainfrom
henryiii:patch-4

Conversation

@henryiii
Copy link
Copy Markdown
Contributor

This updates the build prodedure for modern best practices, using pypa/build. (Delayed) fix for an issue somewhere where it was pointed out this page was old, but forget where it was. Will dig around a bit for it tomorrow.

The page still needs the updates requested in #887; this page seems quite old.

@henryiii
Copy link
Copy Markdown
Contributor Author

Note: we could reduce/remove quite a bit about universal wheels, and mostly make it a note "if you need Python 2+3 support, then"...), and remove some of the Python 2 parts (like how to use 2to3). This page is old.

@webknjaz webknjaz requested review from FFY00, jaraco and pradyunsg May 21, 2021 08:21
Comment thread source/guides/distributing-packages-using-setuptools.rst Outdated
Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
@webknjaz webknjaz changed the title docs: update build procedure Use a PEP517 build front-end in the setuptools guide May 22, 2021
Comment thread source/guides/distributing-packages-using-setuptools.rst
Comment thread source/guides/distributing-packages-using-setuptools.rst
wheel. For details on the naming of wheel files, see :pep:`425`.

If your code supports both Python 2 and 3, but with different code (e.g., you
use `"2to3" <https://docs.python.org/2/library/2to3.html>`_) you can run
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of 2to3 is discouraged if not deprecated. I suggest removing mentions of it.

@henryiii
Copy link
Copy Markdown
Contributor Author

Should I update those things in this PR or in a follow up? I was trying to keep the changes focused, but yes, this page is old!

@jaraco
Copy link
Copy Markdown
Member

jaraco commented May 24, 2021

Happy to accept incremental changes.

@jaraco jaraco enabled auto-merge May 24, 2021 00:50
@webknjaz
Copy link
Copy Markdown
Member

Looks like https://github.com/pypa/pip/pull/10009/files#diff-f35faadf148777b2d0e535cfd8e8f3e1bbc0fecdb7fda5ccd0b9d7d4a4e5471eR31 substantially changed the RST labels it exposes which means that this site needs to fix the links first. This is what hard-blocks the current PR from merging.

@henryiii
Copy link
Copy Markdown
Contributor Author

Can rebase after #902

@jaraco jaraco merged commit 0779498 into pypa:main May 24, 2021
@henryiii henryiii deleted the patch-4 branch May 25, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants