binary-extensions: update Windows instructions#911
Conversation
bhrutledge
left a comment
bhrutledge
left a comment
There was a problem hiding this comment.
I'm not a Windows user, so these are just suggested copy edits for clarity (plus one for spelling).
Co-authored-by: Brian Rutledge <brian@bhrutledge.com>
| ``VCRUNTIME140.dll`` that all previous versions back to 2015 depend on. This | ||
| will add an extra requirement to using your extension on versions of CPython | ||
| that do not include this extra file. To avoid this, you can add the | ||
| compile-time argument ``/d2FH4-``. Recent versions of Python may include this |
There was a problem hiding this comment.
I'd like to put exact numbers, but I'm not sure which ones they are (it might have changed in patch releases, too?)
bhrutledge
left a comment
bhrutledge
left a comment
There was a problem hiding this comment.
I think this reads much better. Thanks!
|
I'm not a Windows user either so I'd feel much more comfortable merging the change if one could be found and posted a review. If nobody is available for some time, we'll merge this as is. |
pfmoore
left a comment
pfmoore
left a comment
There was a problem hiding this comment.
(Windows user here!) This looks good to me, although I only very rarely build C extensions these days, so while the technical details of the content look accurate to me, I'm not an expert.
I'd say this can be merged as is, though - we can always iterate on the technical details if further nuances are reported.
|
Thanks, Paul! |
|
Thanks for the review! I'll try to work on updating macOS and Linux next (though likely after SciPy). |
4 participants
About a month ago Microsoft permanently killed off https://www.microsoft.com/en-gb/download/details.aspx?id=8279 (MSVC 2008 for Python 2.7); it was officially at end-of-really-extended-life-for-python-2.7 since 2018. I don't think details about Python 3.4 are all that interesting to anyone anymore, either.
Included the caveat discovered by matplotlib for MSVC 2019.