Skip to content

Prune project links#919

Merged
pradyunsg merged 4 commits intopypa:mainfrom
bhrutledge:prune-project-links
Jun 22, 2021
Merged

Prune project links#919
pradyunsg merged 4 commits intopypa:mainfrom
bhrutledge:prune-project-links

Conversation

@bhrutledge
Copy link
Copy Markdown
Contributor

After scanning through some of the projects, it seemed like most of the links to IRC and mailing lists are not reliable ways of engaging with a project. Rather than direct users to those, I thought it might be better to rely on each project's repo and documentation to point users in the right direction.

@souldia18
Copy link
Copy Markdown

#917

Copy link
Copy Markdown
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd only trim distutils-sig and #pypa/#pypa-dev IRC channels. Those other mailing lists are likely active.

@webknjaz
Copy link
Copy Markdown
Member

I'd keep them — we have a linkcheck for detecting if something disappears.

@bhrutledge
Copy link
Copy Markdown
Contributor Author

I'd only trim distutils-sig and #pypa/#pypa-dev IRC channels. Those other mailing lists are likely active.

I don't think this is the case:

we have a linkcheck for detecting if something disappears.

True, but that doesn't detect if it's still actively used.

@bhrutledge bhrutledge requested a review from pradyunsg June 21, 2021 12:43
@bhrutledge
Copy link
Copy Markdown
Contributor Author

Based on my last comment, are y'all okay with these changes?

Copy link
Copy Markdown
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, speaking for pip, packaging, packaging.python.org and distutils -- yes, this looks good to me. I imagine that this works for twine and warehouse too.

We should get an OK from the maintainers of the other projects for the corresponding changes here tho.


This PR is removing the IRC links and the link to distutils-sig:

/cc @jaraco for setuptools
/cc @gaborbernat for virtualenv
/cc @vsajip for distlib
/cc @cooperlees for bandersnatch
/cc @agronholm for wheel

And... IDK who to ping for devpi / scikit-build / buildout / bento.

@agronholm
Copy link
Copy Markdown

The wheel part looks good to me, nothing out of place there.

@bhrutledge
Copy link
Copy Markdown
Contributor Author

And... IDK who to ping for devpi / scikit-build / buildout / bento.

Me neither. Which is why I thought it would be better in general to link to consistent things like project sites and documentation, rather than changeable things like communication platforms that require maintainers to keep this page updated.

Copy link
Copy Markdown

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for bandersnatch.

@pradyunsg
Copy link
Copy Markdown
Member

I think it's safe to assume that the remaining folks are also OK with this. If that assumption proves wrong, reverts are cheap; so if someone has concerns, we can revert parts of this later.

@pradyunsg pradyunsg enabled auto-merge June 22, 2021 02:22
@pradyunsg pradyunsg dismissed their stale review June 22, 2021 02:23

Ugh. Why do we have Github's automerge enabled here.

@pradyunsg pradyunsg merged commit f4e97a5 into pypa:main Jun 22, 2021
Comment thread source/key_projects.rst
`Issues <https://github.com/pypa/virtualenv/issues>`__ |
`GitHub <https://github.com/pypa/virtualenv>`__ |
`PyPI <https://pypi.org/project/virtualenv/>`__ |
User IRC:`#pypa <https://web.libera.chat/#pypa>`__ |
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should have added Discord here...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the other projects, I think having a link to Discord in virtualenv's docs might be sufficient.

pypa/virtualenv#2134

@bhrutledge
Copy link
Copy Markdown
Contributor Author

Thanks all!

@bhrutledge bhrutledge deleted the prune-project-links branch June 22, 2021 10:04
Copy link
Copy Markdown

@souldia1 souldia1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😈

@souldia18 souldia18 mentioned this pull request Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants