Skip to content

GitHub Action for updating messages.pot#945

Merged
webknjaz merged 29 commits intopypa:mainfrom
dukecat0:Github-Action-Translation
Aug 24, 2021
Merged

GitHub Action for updating messages.pot#945
webknjaz merged 29 commits intopypa:mainfrom
dukecat0:Github-Action-Translation

Conversation

@dukecat0
Copy link
Copy Markdown
Member

Comment thread .github/workflows/translation.yml Outdated
Comment thread .github/workflows/translation.yml Outdated
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Comment thread .github/workflows/translation.yml Outdated
Comment thread .github/workflows/translation.yml Outdated
Comment thread .github/workflows/translation.yml Outdated
Comment thread .github/workflows/translation.yml Outdated
Comment thread .github/workflows/translation.yml Outdated
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Comment thread .github/workflows/translation.yml Outdated
dukecat0 and others added 4 commits August 25, 2021 00:19
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Comment thread .github/workflows/translation.yml Outdated
Comment thread .github/workflows/translation.yml Outdated
Comment thread .github/workflows/translation.yml Outdated
Comment thread .github/workflows/translation.yml Outdated
dukecat0 and others added 4 commits August 25, 2021 00:22
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Comment thread .github/workflows/translation.yml Outdated
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Comment thread .github/workflows/translation.yml Outdated
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Comment thread .github/workflows/translation.yml Outdated
Comment thread .github/workflows/translation.yml Outdated
dukecat0 and others added 3 commits August 25, 2021 00:27
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@webknjaz webknjaz enabled auto-merge August 24, 2021 16:39
@webknjaz webknjaz added the type: enhancement A self-contained enhancement or new feature label Aug 24, 2021
auto-merge was automatically disabled August 24, 2021 16:39

Head branch was pushed to by a user without write access

@dukecat0
Copy link
Copy Markdown
Member Author

@webknjaz Please enable auto-merge again. I've pushed new commit.

@dukecat0
Copy link
Copy Markdown
Member Author

dukecat0 commented Aug 24, 2021

Thanks for your review!

@webknjaz webknjaz enabled auto-merge August 24, 2021 16:40
@webknjaz webknjaz merged commit cc488ec into pypa:main Aug 24, 2021
@dukecat0 dukecat0 deleted the Github-Action-Translation branch August 24, 2021 16:42
@webknjaz
Copy link
Copy Markdown
Member

@di could you look into allowing bots to bypass branch protection? This is failing https://github.com/pypa/packaging.python.org/runs/3413487705?check_suite_focus=true#step:8:10.

I seem to recall there was an option to add GH Apps to the allowlist. I wonder if GHA can be listed there.

@webknjaz
Copy link
Copy Markdown
Member

Urgh... This doesn't seem to be possible: https://github.community/t/how-to-push-to-protected-branches-in-a-github-action/16101/22?u=webknjaz. @di what can we do about this?

@di
Copy link
Copy Markdown
Member

di commented Aug 24, 2021

I don't think this is possible. I think we probably need to do the same thing that we do for pypa/warehouse here, which is update this file along with every PR that changes a translatable string: https://github.com/pypa/warehouse/commits/main/warehouse/locale/messages.pot

@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Aug 24, 2021

@di what if we'll have a proper GH App entity to add to the allow list? Would that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A self-contained enhancement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants