Conversation
| It is mostly useful if you need to install files which are used by other | ||
| programs, which may be unaware of Python packages. | ||
|
|
||
| Each ``(directory, files)`` pair in the sequence specifies the installation |
There was a problem hiding this comment.
Looks like this one should probably be kept as inline code because it refers to the code snippet above.
There was a problem hiding this comment.
I think, maybe we could instead mark this as translatable on Weblate? Even as inline code.
There was a problem hiding this comment.
Ok, I undo this change. I thought translating the inline code would make sphinx-build complain, but I tested it right now and it doesn't. Actually, when translating Python Docs (also reStructuredText) it is Transifex that complains. Therefore, this change is unnecessary.
I will undo this. I won't revert it thought, because in the same commit I fix a fullstop in this character.
There was a problem hiding this comment.
Perfect, thanks!
P.S. Pro tip: you can add -n to the git revert command and it'll let you make some edits and choose what to commit. This way you can produce partial reverts :)
| programs, which may be unaware of Python packages. | ||
|
|
||
| Each ``(directory, files)`` pair in the sequence specifies the installation | ||
| directory and the files to install there. The ``directory`` must be a relative |
webknjaz
left a comment
There was a problem hiding this comment.
I like this except for those data files changes that seem incorrect.
@meowmeowmeowcat what are your thoughts on this? I think the translatability shouldn't depend on whether something is marked as |
Correct. As I mentioned in a reply above, I thought inline code should not be translated or sphinx-build would complain, and it is not true.
@webknjaz This PR has 2 commits, and you quoted the description of the latter. When you mention 'read-only' flag, do you refer to the former commit (which has the setup() args)? I would be fine not putting in inline, and having it set as read-only. Actually setting as read only was my suggestion it in the comments in Weblate. |
@webknjaz I agree with you here. However, translators will think that |
Oh, my bad 🤦♂️, I keep confusing folks on the Internet :)
That's a great idea! I like it. |
This PR apply the following changes in
source/guides/distributing-packages-using-setuptools.rst:setup()arg names literal (e.g.name,version,description), so that translators know it should not be translated.