Skip to content

Fix broken links#965

Merged
webknjaz merged 5 commits intopypa:mainfrom
dukecat0:patch-2
Aug 24, 2021
Merged

Fix broken links#965
webknjaz merged 5 commits intopypa:mainfrom
dukecat0:patch-2

Conversation

@dukecat0
Copy link
Copy Markdown
Member

@dukecat0 dukecat0 commented Aug 24, 2021

No description provided.

Copy link
Copy Markdown
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use intersphinx references instead of the hardcoded URLs to avoid such problems in the future.

@dukecat0
Copy link
Copy Markdown
Member Author

FIxed!

@dukecat0 dukecat0 requested a review from webknjaz August 24, 2021 09:47
@dukecat0 dukecat0 changed the title Fix a broken link Fix broken links Aug 24, 2021
@webknjaz webknjaz merged commit 1bab44c into pypa:main Aug 24, 2021
@dukecat0 dukecat0 deleted the patch-2 branch August 24, 2021 14:22
@dukecat0 dukecat0 restored the patch-2 branch August 24, 2021 15:55
@dukecat0
Copy link
Copy Markdown
Member Author

@webknjaz Should I open a new PR for using intersphinx references instead of the hardcoded URLs in the docs?

@webknjaz
Copy link
Copy Markdown
Member

If you feel like doing a repo-global crusade — go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants