Skip to content

direct-url: Wrap pip commands with backticks#973

Merged
webknjaz merged 4 commits intopypa:mainfrom
dukecat0:patch-1
Sep 3, 2021
Merged

direct-url: Wrap pip commands with backticks#973
webknjaz merged 4 commits intopypa:mainfrom
dukecat0:patch-1

Conversation

@dukecat0
Copy link
Copy Markdown
Member

@dukecat0 dukecat0 commented Sep 2, 2021

Found this issue when fixing broken links.

@bhrutledge bhrutledge changed the title Add backquotes for commands direct-url: Add backquotes for pip commands Sep 2, 2021
Comment thread source/specifications/direct-url.rst
Comment thread source/specifications/direct-url.rst
Co-authored-by: Brian Rutledge <brian@bhrutledge.com>
Comment thread source/specifications/direct-url.rst Outdated
@webknjaz webknjaz dismissed bhrutledge’s stale review September 2, 2021 17:43

Let's not block this PR on the rendering issues, it solves the problem it's meant to solve (making sure that linkcheck doesn't attempt to follow the fake URLs)

@webknjaz webknjaz requested a review from bhrutledge September 2, 2021 17:44
@webknjaz webknjaz changed the title direct-url: Add backquotes for pip commands direct-url: Wrap pip commands with backticks Sep 2, 2021
@dukecat0 dukecat0 requested a review from webknjaz September 3, 2021 10:32
@webknjaz webknjaz merged commit 55b8b32 into pypa:main Sep 3, 2021
@dukecat0 dukecat0 deleted the patch-1 branch September 3, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants