perf: SpecifierSet use tuple instead of frozenset for _specs#1108
Merged
notatallshaw merged 1 commit intopypa:mainfrom Mar 7, 2026
Merged
perf: SpecifierSet use tuple instead of frozenset for _specs#1108notatallshaw merged 1 commit intopypa:mainfrom
_specs#1108notatallshaw merged 1 commit intopypa:mainfrom
Conversation
Member
Author
|
Big improvement in construction time, mild improvement in resolver loop: |
Contributor
|
Nice, creating sets is expensive. |
henryiii
approved these changes
Mar 7, 2026
Member
Author
|
The moment I merged this I thought of a possible regression in the way I'm deduping specifiers :(. I might have a follow up PR shortly. |
ngoldbaum
pushed a commit
to ngoldbaum/packaging
that referenced
this pull request
Apr 1, 2026
This was referenced Apr 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
SpecifierSet._specsfromfrozensettotupleas it is only ever iterated, never looked up, so tuple is a better fit, more performant, and doesn't cause hash seed based ordering. Strings are deduplicated before constructingSpecifierobjects to reduce the number ofSpecifiersconstructed and hashing strings is much faster than hashingSpecifiers.Since tuples are order-sensitive unlike frozensets,
__hash__,__eq__, and__str__now lazily sort and cache_specsto ensure a canonical order.