perf: Speed up wildcard comparison#1111
Merged
notatallshaw merged 6 commits intopypa:mainfrom Mar 9, 2026
Merged
Conversation
Member
Author
|
Noticeable improvements anywhere this touches: |
henryiii
approved these changes
Mar 8, 2026
ngoldbaum
pushed a commit
to ngoldbaum/packaging
that referenced
this pull request
Apr 1, 2026
This was referenced Apr 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wildcard performance is very slow because it needs to do normalization and padding each run, we can speed that up by:
canonicalize_version+_version_splitresult_pad_versionwith_left_pad, which only pads the prospective side (the right side was computed but never used)This impacts equal wildcard (
==V.*), not equal wildcard (!=V.*), and compatible version~=V.N, I've added one benchmark for compatible version as it's the most complex single specifier and popular with some users.