chore: pin pre-commit file, use dependabot#1133
Merged
Conversation
henryiii
force-pushed
the
henryiii/ci/fullpin
branch
3 times, most recently
from
d312792 to
5119922
Compare
henryiii
commented
Mar 26, 2026
brettcannon
approved these changes
Mar 26, 2026
henryiii
commented
Mar 26, 2026
Contributor
Author
|
I can simplify this, following crate-ci/typos#1528 (comment). I'm not resolving annotated tags correctly as it, but it's an easy fix. This drops the need to do the API stuff at all. |
henryiii
force-pushed
the
henryiii/ci/fullpin
branch
2 times, most recently
from
8d884a3 to
5ef459b
Compare
henryiii
commented
Mar 27, 2026
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Co-authored-by: Brett Cannon <brett@python.org>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
henryiii
force-pushed
the
henryiii/ci/fullpin
branch
from
fc0b371 to
dc059a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since pre-commit already requires stationary pins, there's no update drawback to pinning.
--freezewith pre-commit or prek produces this, and dependabot seems to support it.Adding dependabot for updating these, and adding a 7 day cooldown, like our actions. I have not used dependabot for pre-commit before.
One downside is that we can't ensure that the human readable tag and the SHA match; github will not resolve tags across repos, but it can resolve SHAs across repos. So if someone other than dependabot updates these, we should ensure the SHA matches the tag. I assume mostly dependabot will be doing it, though. (We are protected from this issue for GitHub Actions by zizmor)
I wrote a script to check this for now. Started it with ChatGPT and then iterated on it a lot.