Add type annotations#200
Conversation
pradyunsg
left a comment
pradyunsg
left a comment
There was a problem hiding this comment.
THANK YOU for doing this! This looks great!
A bunch of nit-picks (please do feel free to ignore them/mark them as resolved if you don't think they add value) and a couple of minor concerns around how we're handling some of mypy's weirdness.
|
FYI I do plan to review this, but I'm waiting until #199 lands and I get 19.2 released. |
|
@brettcannon This is ready for you to review. |
brettcannon
left a comment
brettcannon
left a comment
There was a problem hiding this comment.
Thanks for doing this! There's just a couple of places where the types are too strict for the input.
|
Once this PR lands we should open an issue for setting up a |
These settings are in the |
|
@di Sorry, still a little sick so I somehow marked |
| # The following are the flags enabled by --strict | ||
| # | ||
| # Note: warn_unused_ignores is False due to incorrect typeshed annotations for | ||
| # platform.mac_ver() |
There was a problem hiding this comment.
Is there a bug upstream tracking this?
|
@di can you do the merge yourself or do you need one of us to do it? |
4 participants
Fixes #189. Adds Python-2 compatible type annotations.
(cc @pradyunsg @cjerdonek)