Skip to content

Conversation

@sepehr-rs
Copy link
Member

@sepehr-rs sepehr-rs commented Nov 20, 2025

Fixes #13618
This resolves the issue, though I’m not certain it’s the ideal place for the fix. If needed, we can move the solution further down in the stack.

@notatallshaw
Copy link
Member

notatallshaw commented Nov 21, 2025

I've not spent any time looking at the code, but I would be pretty nervous about removing the marker information until right before the error message.

Even if that marker information isn't used now someone might want to use it later and be surprised to find all marker information stripped, and there's no comment as to why that happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

extra incorrectly shown on installation error

2 participants