Separate pip wheel command from operation #2411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I believe #2412 will fix the PEP 8 test failures. |
pep8==1.6 added some additional checks that pip currently fails. This prevents Travis CI failures until folks can evaluate whether the issues should be fixed in the code or ignored.
By extracting the logic into `pip.operations.wheel`, the hope is that folks could do a `wheel` programmatically more easily. It also has greater separation of concerns and should allow people to work in parallel with less chance of merge conflicts. Continuing work started in pypa#2173, pypa#2404, and pypa#2410.
msabramo
force-pushed
the
extract_wheel_operation
branch
from
aae0471 to
6614c4d
Compare
Contributor
Author
|
Gah. Doesn't merge cleanly. Should I update this? |
Member
|
I'd say you could rebase on develop to have a clean merge (and remove the pep8 part). |
Member
There was a problem hiding this comment.
I think the session building part should stay on the commands side and the session would be an other argument of the build_wheel function.
Contributor
Author
|
This is a mess now. I'm going to close this and possibly redo later. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By extracting the logic into
pip.operations.wheel, the hope is thatfolks could do a
wheelprogrammatically more easily.It also has greater separation of concerns and should allow people to
work in parallel with less chance of merge conflicts.
Continuing work started in #2173, #2404, and #2410.