Vendor in requirementslib==2.0.0 & drop pip-shims & revert sysconfig patch w/ safer setuptools usage
#5228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…create_tracked_tempfile." This reverts commit 9583f41.
matteius
changed the title
requirementslib==2.0.0 and drop pip-shims
matteius
added
PR: awaiting-review
matteius
changed the title
requirementslib==2.0.0 and drop pip-shimsrequirementslib==2.0.0 & drop pip-shims & revert sysconfig patch w/ safer setuptools usage
Contributor
|
We still need to fix the merge conflicts @matteius |
oz123
approved these changes
Aug 24, 2022
Member
Author
|
@oz123 I had merged main into this branch and resolved them, squash and merge did not show any conflicts so I went ahead and merged, thanks for your review! |
yeisonvargasf
pushed a commit
to yeisonvargasf/pipenv
that referenced
this pull request
Nov 19, 2022
…fig patch w/ safer setuptools usage (pypa#5228) * Vendor in requirementslib 2.0.0 * Drop sysconfig default patch. * Remove setuptools import usages in pipenv. * Add news fragment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor in requirementslib==2.0.0 and drop pip-shims entirely.
Some systems have patched sysconfig differently, and from this discussion (pypa/setuptools#3544) it would appear that importing setuptools packages is problematic