Issue 5273 unable to install extras because constraints are not recognized #5274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteius
approved these changes
Aug 18, 2022
Member
|
@dqkqd Would you add a news fragment? |
Contributor
Author
Is a new fragment is required? I thought it’s just a bug from my previous PR. If it’s necessary, I will add that after getting back home. |
Member
|
@dqkqd because it made it into a pypi release, we should include a news fragment. Since you are away right now I am going to merge this one and add a news fragment on your behalf, since I just bumped up against this issue. |
Contributor
Author
|
@matteius , thank you. |
matteius
changed the title
yeisonvargasf
pushed a commit
to yeisonvargasf/pipenv
that referenced
this pull request
Nov 19, 2022
* Add more test for get_constraints_from_deps * Use pip's check_invalid_constraint_type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
This fixes #5273
The fix
Convert
RequirementintoInstallRequirementbefore checking constraint.The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.