Skip mercurial tests when hg is not available #426
Conversation
testing/test_mercurial.py
Outdated
|
|
||
|
|
||
| with warnings.catch_warnings(): | ||
| warnings.filterwarnings('ignore') |
There was a problem hiding this comment.
Note that I hate this but I have no clue how to otherwise make pytest not crash about has_command() throwing a warning. Nor that I have any clue why a command returning a bool would issue a warning that it returns False.
Mercurial is broken (read: crashing with bus error) on SPARC. Nevertheless, many packages need setuptools_scm even if we never ever use Mercurial checkouts. This patch makes it possible to run the test suite successfully when Mercurial is not available on the system.
|
Thanks, I will merge as is and refine later If you like you can take a look at using xfail for this |
I don't think xfail is correct here. The way I understand it, xfail means that the package or tests are broken. For unsatisfied dependency (which is a clear cut case of 'we cannot test this properly') I think skip is more correct. |
|
By the way, I can look at doing something similar for git, if you're interested. |
|
i am, if you like you can also take a look at enhancing the error message we give when the detected scm is not installed |
2 participants
Mercurial is broken (read: crashing with bus error) on SPARC.
Nevertheless, many packages need setuptools_scm even if we never ever
use Mercurial checkouts. This patch makes it possible to run the test
suite successfully when Mercurial is not available on the system.