Fix flake8-return warnings #4169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
return
branch
2 times, most recently
from
7a63703 to
7b3e3f3
Compare
abravalheri
reviewed
Jan 5, 2024
DimitriPapadopoulos
force-pushed
the
return
branch
3 times, most recently
from
694b3ae to
323dff5
Compare
Contributor
|
Thank you very much @DimitriPapadopoulos . Should |
Contributor
Author
|
Yes, it could be added. Some rules should be disabled though. I have not fixed such issues: if ...:
return ...
else:
return ...Thanks to the symmetry, I find the above more readable than: if ...:
return ...
return ...It's your call... |
RET502 Do not implicitly `return None` in function able to return non-`None` value
RET502 Do not implicitly `return None` in function able to return non-`None` value
RET503 Missing explicit `return` at the end of function able
to return non-`None` value
RET504 Unnecessary assignment to `...` before `return` statement
Contributor
|
Thank you very much @DimitriPapadopoulos, let's merge this for now...
I am not sure about this. I am more keen to keep the linter configuration as dry as possible, ideally just working out of the box. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix flake8-return issues reported by ruff 0.1.9.
Pull Request Checklist
newsfragments/.(See documentation for details)