Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an interim solution, suppress the warning that the imp module is d… #1238

Merged
merged 2 commits into from Oct 31, 2018

Conversation

Projects
None yet
2 participants
@pfmoore
Copy link
Member

commented Oct 31, 2018

…eprecated

@pfmoore

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2018

@gaborbernat What's the failure here? It seems to be reporting lint problems on a load of files I didn't change :-(

@pfmoore

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2018

Looks like master is also failing the same check. Am I therefore good to merge this?

@pfmoore pfmoore added this to the 16.1 milestone Oct 31, 2018

@pfmoore

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2018

@gaborbernat Can this go into 16.1? I know it's a bit last minute, but I hadn't realised no-one had addressed it till just now :-(

@gaborbernat

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2018

@pfmoore sure.

pfmoore and others added some commits Oct 31, 2018

@gaborbernat gaborbernat force-pushed the pfmoore:suppress_warning branch from 4038df4 to a6650d9 Oct 31, 2018

@gaborbernat gaborbernat self-assigned this Oct 31, 2018

@gaborbernat gaborbernat merged commit 379f748 into pypa:master Oct 31, 2018

1 check passed

pypa.virtualenv Build #pypa.virtualenv_20181031.08 succeeded
Details
@pfmoore

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2018

Cool, thanks :-)

@pfmoore pfmoore deleted the pfmoore:suppress_warning branch Oct 31, 2018

@gaborbernat

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2018

@pfmoore virtualenv 16.1.0 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.