hir-94: vercel.json cron config + GET-driven cron handlers#20
Open
jaredzwick wants to merge 1 commit intopypesdev:mainfrom
Open
hir-94: vercel.json cron config + GET-driven cron handlers#20jaredzwick wants to merge 1 commit intopypesdev:mainfrom
jaredzwick wants to merge 1 commit intopypesdev:mainfrom
Conversation
The /api/cron/* routes only had POST handlers, so nothing actually fired them on a schedule. Queued emails just sat in the database; expiring OAuth tokens silently rotted; silent-reply follow-ups never flushed. The recommended-frequency comments in each handler were aspirational — there was no scheduler. - vercel.json: cron config invoking /api/cron/process-queue and /api/cron/process-followups every 5 minutes, /refresh-tokens every 30 minutes (matches the per-route docstrings). - All three cron routes now expose a single shared `handle` for both GET and POST. Vercel Cron only sends GET, so GET previously did nothing useful (returned a health-check JSON). POST callers (manual triggers, external runners) keep working with no behavior change. - Auth lifted into src/lib/cronAuth.ts — pure verifyCronAuth() that returns ok / 500 misconfig / 401. 10 vitest specs cover scheme case-sensitivity, prefix-attack rejection, missing/empty header, empty/missing secret, and the happy path. No schema, no migrations. tsc clean. test:int 105 passed (only the pre-existing PAYLOAD_SECRET api.int.spec.ts failure remains, same as main). Co-Authored-By: Paperclip <noreply@paperclip.ing>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /api/cron/* routes only had POST handlers, so nothing actually
fired them on a schedule. Queued emails just sat in the database;
expiring OAuth tokens silently rotted; silent-reply follow-ups never
flushed. The recommended-frequency comments in each handler were
aspirational — there was no scheduler.
/api/cron/process-followups every 5 minutes, /refresh-tokens every
30 minutes (matches the per-route docstrings).
handlefor bothGET and POST. Vercel Cron only sends GET, so GET previously did
nothing useful (returned a health-check JSON). POST callers
(manual triggers, external runners) keep working with no behavior
change.
returns ok / 500 misconfig / 401. 10 vitest specs cover scheme
case-sensitivity, prefix-attack rejection, missing/empty header,
empty/missing secret, and the happy path.
No schema, no migrations. tsc clean. test:int 105 passed (only the
pre-existing PAYLOAD_SECRET api.int.spec.ts failure remains, same
as main).
Co-Authored-By: Paperclip noreply@paperclip.ing
🤖 Generated with Claude Code