-
Notifications
You must be signed in to change notification settings - Fork 107
Closed
Description
two quick things:
- I think this:
if "include_zero" not in kwargs or kwargs["include_zero"] is True:
phi_comps = {k: phi_comps[k] for k in keys if phi_comps[k] > 0.0}
should be:
if "include_zero" not in kwargs or kwargs["include_zero"] is False:
phi_comps = {k: phi_comps[k] for k in keys if phi_comps[k] > 0.0}
As is, seems setting the kwarg 'include_zero' to True will actually exclude zero (like the docstring says - why do that anyway ?)
- Propose another
kwargcalledlabel_compsthat takes a list of potential components for the labels. Basically, any combo of['name', 'phi_comp', 'phi_percent']since labels can get cluttered in the presence of hella obs groups. If no objection, I'll PR both of these
briochh
Metadata
Metadata
Assignees
Labels
No labels