Feat pst_from: Flexible pathing for input array and list files; option to write tpl files to a subfolder #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implemented by refactoring file handling from os.path to use pathlib * input array or list text files can be in the model workspace a subfolder, or another folder outside of the model workspace * regardless of the input file location, "org" and "mult" files are kept in a flat structure in their respective folders as before * the resulting model input files are written to the same relative locations as their original versions * tpl and pilot point-related files are still written to the root level of the model workspace * tests include single array files with par_types zone, pilotpoints and grid, an array file list with par_type=zone, and single list files with par_type=constant
…thin the model workspace fix(pst_from): issue with in_fileabs and in_filepst when par_style != 'multiplier'
…ion cases where there is not 'mlt_file' column in the mult2model_info dataframe fix(pst_from.write_array_tpl): order of operations in _check_diff fix(pst_from._par_prep): use predefined org_file path for case with no header tests(pst_from): add basic test for 'direct' parameterization with datafiles in subfolder; make list testdata one-based
Collaborator
|
Thanks @aleaf ! I'm gonna kick tires a little tomorrow on a few active use cases but this looks excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intended to allow users to input files to
PstFrom.add_parametersthat aren't at the root level of the model workspace. It also includes an option to write template files to a subfolder (via atpl_subfolderargument toPstFrom.__init__()).This is mostly implemented by refactoring pathing to use
pathlibinstead ofos.path. The following types of pathing situations should work (see the tests inautotest/pst_from_tests.py:TestPstFromfor more details):@jtwhite79 @briochh Let me know what you think!