Skip to content

Feat chunks #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2021
Merged

Feat chunks #214

merged 2 commits into from
Jan 19, 2021

Conversation

@jtwhite79
Copy link
Collaborator

@jtwhite79 jtwhite79 commented Jan 19, 2021

wove the chunk_len arg into the PstFrom constructor and also added logic to not spawn an mp.Pool if there is only one chunk. So to disable multiprocessing, just pass a really large chunk_len

@jtwhite79 jtwhite79 requested a review from briochh January 19, 2021 02:51
briochh
briochh approved these changes Jan 19, 2021
View reviewed changes
Copy link
Collaborator

@briochh briochh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tidy J

@briochh briochh merged commit 8b0d84c into pypest:develop Jan 19, 2021
@coveralls
Copy link

coveralls commented Jan 19, 2021

Coverage Status

Coverage increased (+0.7%) to 77.795% when pulling 7d90ee5 on jtwhite79:feat_chunks into 87d05d6 on pypest:develop.

@jtwhite79 jtwhite79 deleted the feat_chunks branch December 5, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briochh briochh briochh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtwhite79 @coveralls @briochh