Refactoring shortnames option #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Starting shortnames refactor * More carefully handling shortname mapping for repeat pst builds in pstfrom * need to pad tpl entries to prevent excess precision loss * control file may not have parameter group section * Tidy longname refs from pst_utils * Tidy old long name refs from pst_from * Tidy longname refs from pp_utils * Short name test can now be shorter
…o feat_shortnames
Collaborator
Author
|
somewhat related to #280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing to "simplify" setting up parameters and observations with
pst_fromandlongnames=False. Parameter and observations names with will default top{x}ando{x}, respectively, wherexis effectively a counter. Two additional files will be written tomapthese names to theirlongnamecounterparts allowing the parameter and observation metadata to still be stored and used in processing (while maintaining better support for classic PEST and PEST UTILS).Using the
pyemu.Pst()function to load in the pest control file will attempt to populate the metadata columns ofparameter_dataandobservation_datawith the metadata stored in these helper files.These changes do actually simplify the general par and obs naming methods, however, obviously they may break peoples current
longnames=Falsesetups. Happy to leave on a branch for now if folks want to test more thoroughly.