Skip to content

Conversation

@briochh
Copy link
Collaborator

@briochh briochh commented Apr 3, 2025

This PR changes default behaviour to write ensembles to dense binary format when the number of obs or parameters exceeds 1e6.

This is consistent with changes coming in PEST++ and favours the dense binary format for more reliable and faster IO when the ensembles get big.

USERS BEWARE: Will add a '.bin' extension to the requested filename if nobs or npars exceeds 1e6. Happy to discuss alternative options -- like error raising, or agnostically propagating filename but this seems the safest and leas disruptive. Ensemble.to_binary() should now return the written filename.

@briochh briochh requested a review from jtwhite79 April 3, 2025 00:07
@coveralls
Copy link

Coverage Status

coverage: 79.088% (+0.2%) from 78.91%
when pulling ca340d2 on briochh:feat_densedefault
into b8d6033 on pypest:develop.

@briochh briochh merged commit 34c84e1 into pypest:develop May 2, 2025
25 of 26 checks passed
@briochh briochh deleted the feat_densedefault branch August 4, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants