fix: remove ultranormalization of distribution filenames #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #123. Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
di
approved these changes
May 15, 2025
This was referenced May 15, 2025
woodruffw
added a commit
that referenced
this pull request
Jun 3, 2025
This fixes an error introduced with #124 -- that PR correctly dropped our "ultranormalization" of distribution names, but it didn't account for the fact that we were comparing distribution names as strings, rather than as parsed forms. See pypa/gh-action-pypi-publish#365 for more context. Signed-off-by: William Woodruff <william@trailofbits.com>
facutuesca
pushed a commit
that referenced
this pull request
Jun 3, 2025
* bugfix: compare distribution names by parsed forms This fixes an error introduced with #124 -- that PR correctly dropped our "ultranormalization" of distribution names, but it didn't account for the fact that we were comparing distribution names as strings, rather than as parsed forms. See pypa/gh-action-pypi-publish#365 for more context. Signed-off-by: William Woodruff <william@trailofbits.com> * ignore long line Signed-off-by: William Woodruff <william@trailofbits.com> --------- Signed-off-by: William Woodruff <william@trailofbits.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This retains validation of distribution filenames, but does not go beyond whatever validation
packaging's APIs already do (which will hopefully become stricter over time).Closes #123.
CC @di