Skip to content

Conversation

@woodruffw
Copy link
Member

@woodruffw woodruffw commented Jul 15, 2024

WIP. Fixes #33.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw marked this pull request as ready for review July 15, 2024 20:13
@woodruffw woodruffw requested a review from facutuesca July 15, 2024 20:15
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw requested a review from facutuesca July 16, 2024 20:35
Copy link
Collaborator

@facutuesca facutuesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left only a couple docstring and log message suggestions

Co-authored-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
@woodruffw woodruffw merged commit 8619721 into main Jul 17, 2024
@woodruffw woodruffw deleted the ww/no-io branch July 17, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API: Don't do I/O in sign/verify APIs

3 participants