Skip to content

Maintainers data in json api. Fixes #9978 #16780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterk wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Maintainers data in json api. Fixes #9978 #16780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c617e22
Maintainers data in json api. Fixes #9978
peterk Sep 23, 2024
dec14b0
Merge branch 'main' into feature-9978
peterk Oct 13, 2024
efa29d5
Merge branch 'main' into feature-9978
peterk Oct 28, 2024
045929b
Merge branch 'main' into feature-9978
peterk Nov 26, 2024
b24b61a
Merge branch 'main' into feature-9978
peterk Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/unit/legacy/api/test_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ def test_renders(self, pyramid_config, db_request, db_session):
"license_files": None,
"maintainer": None,
"maintainer_email": None,
"maintainers": [],
"name": project.name,
"package_url": "/the/fake/url/",
"platform": None,
Expand Down Expand Up @@ -578,6 +579,7 @@ def test_detail_renders(self, pyramid_config, db_request, db_session):
"license_files": None,
"maintainer": None,
"maintainer_email": None,
"maintainers": [],
"name": project.name,
"package_url": "/the/fake/url/",
"platform": None,
Expand Down Expand Up @@ -672,6 +674,7 @@ def test_minimal_renders(self, pyramid_config, db_request):
"license_files": None,
"maintainer": None,
"maintainer_email": None,
"maintainers": [],
"name": project.name,
"package_url": "/the/fake/url/",
"platform": None,
Expand Down
21 changes: 21 additions & 0 deletions warehouse/legacy/api/json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
Project,
Release,
ReleaseURL,
Role,
User,
)
from warehouse.utils.cors import _CORS_HEADERS

Expand Down Expand Up @@ -144,6 +146,24 @@ def _json_data(request, project, release, *, all_releases):
for vulnerability_record in release.vulnerabilities
]

# Serialize maintainers and their project role.
maintainers = [
{
"username": maintainer.username,
"name": maintainer.name,
"role_name": maintainer.role_name,
}
for maintainer in (
request.db.query(Role)
.join(User)
.filter(Role.project == project)
.distinct(User.username)
.order_by(User.username)
.with_entities(User.username, User.name, Role.role_name)
.all()
)
]

data = {
"info": {
"name": project.name,
Expand All @@ -160,6 +180,7 @@ def _json_data(request, project, release, *, all_releases):
"author_email": release.author_email,
"maintainer": release.maintainer,
"maintainer_email": release.maintainer_email,
"maintainers": maintainers,
"requires_python": release.requires_python,
"platform": release.platform,
"downloads": {"last_day": -1, "last_week": -1, "last_month": -1},
Expand Down