Skip to content

optimization: only fetch bigquery schemas once per run in sync_bigquery_release_files #17451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ewdurbin merged 2 commits into from
Jan 18, 2025
Merged

optimization: only fetch bigquery schemas once per run in sync_bigquery_release_files #17451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc4841a
optimization: only fetch bigquery schemas once per run in sync_bigque…
ewdurbin Jan 18, 2025
8f3e208
Merge branch 'main' into optimize_sync_bigquery_release_files
ewdurbin Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion warehouse/packaging/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,13 +375,17 @@ def sync_bigquery_release_files(request):
request.tm.commit()
request.tm.begin()

table_schemas = {
table_name: bq.get_table(table_name).schema for table_name in table_names
}

for missing_file in missing_files:
# Add the objects back into the new session
request.db.add(missing_file)
release_file = missing_file.file

for table_name in table_names:
table_schema = bq.get_table(table_name).schema
table_schema = table_schemas[table_name]

# Using the schema to populate the data allows us to automatically
# set the values to their respective fields rather than assigning
Expand Down