fix(forklift): Distinguish deleted project filename error (#18671)

[Delta17920]

Update upload validation to check project lifecycle_status for file conflicts. Provides a more specific error message when the conflict is with an archived project. Fixes #18671

Proof / Test Output

This ss shows the new test (test_upload_fails_with_deleted_project_conflict) and all other tests in the file passing after the code change:

[di]

Thanks for the PR.

Note that whether or not the project is archived has no bearing on whether the given file has been deleted -- an archived project can have 'live' files and an active project can have 'deleted' files.

The actual error message we're trying to improve is this one:

warehouse/warehouse/forklift/legacy.py

Lines 1145 to 1159 in 5f7e35c

	# Check to see if the file that was uploaded exists in our filename log
	if request.db.query(
	request.db.query(Filename).filter(Filename.filename == filename).exists()
	).scalar():
	request.metrics.increment(
	"warehouse.upload.failed", tags=["reason:filename-reuse"]
	)
	raise _exc_with_message(
	HTTPBadRequest,
	"This filename has already been used, use a "
	"different version. "
	"See "
	+ request.help_url(_anchor="file-name-reuse")
	+ " for more information.",
	)

Given that the previous checks are looking for "live" files (the File model) we should only arrive at this error message in the case if the filename is not 'live' but was previously used and is recorded (the Filename model).

So, we are already distinguishing between 'deleted' and 'live' files when returning this error message, we just need to be more clear in this error message that the file has since been 'deleted' and is no longer 'live'.

[Delta17920]

on it

[Delta17920]

Thanks for the review, @di ! I've pushed the update. I just changed the error message string in legacy.py and updated the matching test, as you suggested.