-
Notifications
You must be signed in to change notification settings - Fork 318
added JSON Topic for use with micropython-upip #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @awachtler! Great, thanks a lot for your proposal. I am not sure when exactly I will have a moment to give a review, but I will try to take a good look at it in the coming days. The functionality looks nice already :) |
Hi @awachtler! Sorry getting back to it only after such a delay, but I've taken a look and had to look a bit into Micropython to get slightly more familiar, but it looks like a nice addition in my opinion ;). I will add a few comments, but I think it'll make it nicely into master :). @mplanchard, if you'd have some time, could you give a second opinion? But to give a better idea and mention this feature to the world, you could add an example of using this endpoint with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I have left a couple of comments :)
- could you align with PEP 503?
- if you could add a unit test, would be very grateful!
- added redirect if package name is not normalized - raise 404 error if package is not found
@dee-me-tree-or-love, I just added normalized package name redirecting. While testing I found that I should raise 404 error in case of invalid package name. The use-case documentation for micropython I will add within the next days. |
Just updated README.rst |
@awachtler great! Thanks a lot, I've seen the newly added changes! Looks great to me! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted a typo ;)
Hallo, @dee-me-tree-or-love, thanks for your careful review, the typo was just fixed. |
@awachtler hey great! Thanks a lot for the fixes and the friendly bump to review, merging it 👍 |
This patch adds a json-info url to pypiserver, which is needed for micropython-upip.
The change enables pypi-server to be used as local package server for micropython projects.
If server is queried like this: http://gretel-2:8080/pypiserver/json it returns this JSON data:
I would be happy, if this change can make it to the master branch.
Best Regards, Axel.