Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
cc @juanitorduz / @theorashid |
|
Nice, yeah we should get this in. Immediate responses:
|
|
|
Very cool! Thanks for contributing! |
|
CI / examples (3.13) appears to be failing, but I'm not sure it's related to my change @fehiepsi . Any thoughts? |
We are encountering it on other PRs too. I presume the dataset download URL is inaccessible. We are investigating this issue. |
|
Could you sync to master? |
| @@ -0,0 +1,338 @@ | |||
| { | |||
There was a problem hiding this comment.
can we add
!pip install -q numpyro@git+https://github.com/pyro-ppl/numpyro
as other notebooks? See https://num.pyro.ai/en/stable/tutorials/bayesian_regression.html
Also the line
assert numpyro.__version__.startswith("0.20.0")
Reply via ReviewNB
| @@ -0,0 +1,338 @@ | |||
| { | |||
There was a problem hiding this comment.
Suggestion! Show the trace and show that we have recovered the parameters, for example like in https://num.pyro.ai/en/stable/tutorials/other_samplers.html
Reply via ReviewNB
|
Thanks @thomaspinder ! I left two minor comments. From my side, it's good to go :) I fixed the unrelated errors in #2151 so after you rebase, this should be fine :) |
|
Nice idea @juanitorduz! I have addressed both of your comments. |
GPJax is a library built upon Numpyro and Flax's NNX module that allows for flexible Gaussian processes to be implemented. Within the past 6 months, a series of PRs to GPJax have brought it closer to numpyro and it can now be easily integrated into a larger numpyro model. This PR demonstrates how people can achieve that by leveraging the synergies present between Numpyro and GPJax.