doc(gh-2187): add math explanations for Normal, Cauchy, and Exponential distributions#2188
Merged
Qazalbash merged 4 commits intoMay 11, 2026
Merged
Conversation
…butions (pyro-ppl#2187) Add LaTeX math explanations, parameter documentation, and method docstrings following the format established in pyro-ppl#2185 (Beta/BetaProportion). Covers PDF, log_prob, CDF, ICDF, mean, variance, entropy, and sample for each distribution. Cauchy docstrings note the undefined mean/variance.
Collaborator
|
Thanks @kimjune01 |
Collaborator
|
Please remove the "Fixes #" line from the description. #2187 is a tracking issue and will remain open after this PR merges. No worries, I removed it myself. |
Qazalbash
requested changes
May 9, 2026
Collaborator
Qazalbash
left a comment
Qazalbash
left a comment
There was a problem hiding this comment.
Overall looks good. Some changes are requested.
- Add equation for Normal.log_cdf with note about jax.scipy.stats.norm.logcdf implementation - Replace \tfrac with \frac in Cauchy.icdf equation Addresses review comments from @Qazalbash in PR pyro-ppl#2188
Qazalbash
approved these changes
May 11, 2026
Collaborator
Qazalbash
left a comment
Qazalbash
left a comment
There was a problem hiding this comment.
I have improved the documentation of some methods of Normal distribution. This PR is ready for merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds mathematical explanations and implementation details to the docstrings for the
Normal,Cauchy, andExponentialdistributions, continuing the documentation effort from #2185.