Conversation
neerajprad
commented
Feb 27, 2019
| # assert that rng is PRNGKey and not mtrand.RandomState object from numpy. | ||
| assert not isinstance(rng, mtrand.RandomState) | ||
| args = deque(args) | ||
| loc = kwargs.get('loc', args.popleft() if len(args) > 0 else 0) |
Member
Author
There was a problem hiding this comment.
This is to have the same behavior as logpdf. In addition the third arg can be size as is the case with scipy.stats.
fehiepsi
reviewed
Feb 27, 2019
test/test_distributions.py
Outdated
|
|
||
|
|
||
| @pytest.mark.parametrize("alpha", [1e-4, 1e-3, 1e-2, 1e-1, 1e0, 1e1, 1e2, 1e3, 1e4]) | ||
| @pytest.mark.xfail(reason="TypeError: __invert__() missing 1 required") |
Member
There was a problem hiding this comment.
Opps... I guess this is due to JAX version? The test passed in my system (CPU).
Member
Author
There was a problem hiding this comment.
What's the version of JAX you are using?
Member
Author
There was a problem hiding this comment.
Oh..you are right, just updating jax now.
Member
|
@neerajprad The inverse error is due to a typo, which is fixed at jax-ml/jax#388. I don't know which operator called it so we might enable the test later when a new version of jax is released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fehiepsi - Sorry if I merged #7 too soon. 😄 I have added an xfail for the last test, feel free to push to this branch directly to resolve it.