feat: Improve dev experience by using local S3 #244
Merged
frgfm merged 36 commits intopyronear:mainfrom Oct 20, 2023
Merged
Conversation
update dependencies for localstack
create empty nbucket for dev environment
add localstack service
frgfm
reviewed
Mar 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #244 +/- ##
==========================================
- Coverage 94.95% 94.78% -0.17%
==========================================
Files 63 57 -6
Lines 1505 1322 -183
==========================================
- Hits 1429 1253 -176
+ Misses 76 69 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
fix typo issue
sleep, to ensure local aws was created
make sure we execute the awslocal command in the localstack container
clean and simplify localstack service
add media folder
use localstack on docker-compose-dev tests
Contributor
Author
frgfm
requested changes
Apr 11, 2023
Member
frgfm
left a comment
There was a problem hiding this comment.
My bad there are still a few things to fix the CI:
- we need to integrate that also in the python client test suite
- strangely the test job is failing now 🤔
Could you take a look please?
Member
|
Any update @Acruve15 ? 😃 |
|
Hi @Acruve15, very nice addition! I tried to run this locally but |
sleep to make sure localstack is up and running
better manage sleep time in CI
use docker compose v2
dependencies are not needed
3 tasks
Contributor
Author
|
@frgfm thx for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked to Issue 217. Developing locally is not possible if the developer does not have an AWS S3 access.
What was done
We used localstack to solve this issue.