Skip to content

fix: authentication, alert payload and exception handling in api_e2e.py#245

Merged
frgfm merged 9 commits intomainfrom
fix-api_e2e
May 28, 2023
Merged

fix: authentication, alert payload and exception handling in api_e2e.py#245
frgfm merged 9 commits intomainfrom
fix-api_e2e

Conversation

@blenzi
Copy link
Copy Markdown

@blenzi blenzi commented Apr 9, 2023

This PR fixes the script for end-to-end tests.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2023

Codecov Report

Merging #245 (24d1b99) into main (2b00bb3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files          60       60           
  Lines        1395     1395           
=======================================
  Hits         1325     1325           
  Misses         70       70           
Flag Coverage Δ
client 100.00% <ø> (ø)
unittests 94.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@frgfm
Copy link
Copy Markdown
Member

frgfm commented May 28, 2023

Hey there :)

Thanks a lot for the fix! Could you merge main into this branch please? 🙏 (#255 re-enabled the script job)
Perfect occasion to make this script work properly!

@frgfm frgfm self-assigned this May 28, 2023
@frgfm frgfm added type: fix Something isn't working ext: scripts labels May 28, 2023
@frgfm frgfm added this to the 0.2.0 milestone May 28, 2023
@frgfm
Copy link
Copy Markdown
Member

frgfm commented May 28, 2023

I took the liberty to apply the multiple fixes, everything's alright now 👍

@frgfm frgfm merged commit d8f03c9 into main May 28, 2023
@frgfm frgfm deleted the fix-api_e2e branch May 28, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ext: scripts type: fix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants