fix: Adds missing reference to the endpoint_url for the S3 proxy#294
Merged
fix: Adds missing reference to the endpoint_url for the S3 proxy#294
Conversation
Codecov Report
@@ Coverage Diff @@
## main #294 +/- ##
=======================================
Coverage 95.17% 95.17%
=======================================
Files 66 66
Lines 1576 1576
=======================================
Hits 1500 1500
Misses 76 76
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
|
@Nastaliss Would you mind adding a PR description and creating an issue referencing all the PRs on that topic please? 🙏 |
frgfm
requested changes
Oct 18, 2023
Member
frgfm
left a comment
frgfm
left a comment
There was a problem hiding this comment.
No need for an extra instance attribute, I'll edit the PR 👍
| self, region: str, endpoint_url: str, access_key: str, secret_key: str, bucket_name: str, proxy_url: str | ||
| ) -> None: | ||
| _session = boto3.Session(access_key, secret_key, region_name=region) | ||
| self.endpoint_url = endpoint_url |
Member
There was a problem hiding this comment.
No need we have
self._s3.meta.endpoint_url
frgfm
changed the title
Collaborator
Author
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The endpoint_url reference in the method to generate file download URL is missing. This PR fixes that