Conversation
|
Thanks for this nice addition @frgfm ! I believe the errors in the CI come from I would suggest monitoring also the alert notifications, in order to remove that from the db, as you suggested in #304. |
blenzi
left a comment
There was a problem hiding this comment.
Thanks a lot for these additions, @frgfm !
I have no experience with PostHog but if I understand well, it will not have access to our db. Therefore, to maximize the possibilities it offers, we probably need some more detailed, human-readable information about the events. This will be required when analyzing individual alerts, statistics per site / group, etc. So I added in a few places the suggestion to include device / site / group name, updated information, etc. What do you think ?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
- Coverage 94.95% 94.59% -0.36%
==========================================
Files 63 63
Lines 1505 1592 +87
==========================================
+ Hits 1429 1506 +77
- Misses 76 86 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
So apart from "updated info" (feels like dumping the payload otherwise), I added everything that was immediately available (not requiring another DB operations) |
This PR introduces the following modifications:
Any feedback is welcome!
cf. #304