Add alert-specific URL and improve Slack notification message#566
Add alert-specific URL and improve Slack notification message#566MateoLostanlen merged 9 commits intomainfrom
Conversation
- Include alert ID in platform URL (e.g. /alert/38187) when available - Shorten S3 image URL using Slack mrkdwn link format - Fix French accents in notification text - Fix image alt text placeholder
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
==========================================
+ Coverage 88.07% 88.15% +0.07%
==========================================
Files 51 51
Lines 2147 2152 +5
==========================================
+ Hits 1891 1897 +6
+ Misses 256 255 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @MateoLostanlen, thanks for the PR. Few questions before reweing Have you tested on a dedicated test slack channel ? Also, could you add a screenshot of how it renders on slack ? When I have tested in #547 it was looking like below (unfortunately the image is no more available in my example)
|
Slack rejected image blocks with invalid_blocks on internal/presigned URLs. Replace bare platform URL with action-verb CTA link.
fe51
left a comment
There was a problem hiding this comment.
Hello @MateoLostanlen ! Thank for this PR and discussion about it ! Good to me
fe51
left a comment
There was a problem hiding this comment.
Why do you have the fallback for the platform URL in two places: in the compose file and in the config file? Shouldn't it just be one or the other?
Why do you have the fallback for the URL in two places: in the compose file and in the config file? Shouldn't it just be one or the other?
fe51
left a comment
There was a problem hiding this comment.
Thanks for the udpates, all good now !

Uh oh!
There was an error while loading. Please reload this page.