cache model weights under versioned slug and purge stale ones#357
Merged
MateoLostanlen merged 1 commit intodevelopfrom Apr 21, 2026
Merged
cache model weights under versioned slug and purge stale ones#357MateoLostanlen merged 1 commit intodevelopfrom
MateoLostanlen merged 1 commit intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #357 +/- ##
===========================================
- Coverage 73.93% 73.85% -0.09%
===========================================
Files 6 6
Lines 633 631 -2
===========================================
- Hits 468 466 -2
Misses 165 165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fe51
approved these changes
Apr 21, 2026
Member
fe51
left a comment
fe51
left a comment
There was a problem hiding this comment.
Nice catch and quick fix ! Thanks !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, bumping MODEL_REPO_ID (e.g. plucky-pelican_v7.0.0 → v7.1.0) had no effect on existing deployments: the local archive name (ncnn_cpu.tar.gz) and extract dir (ncnn_cpu/)
are unversioned, so the is_file() / is_dir() guards skipped the re-download and NCNN loaded the old weights.
Now cached weights live under data/models/{MODEL_SLUG}/ (slug derived from MODEL_REPO_ID). A version bump lands in a fresh path, and on download we purge any other slug plus the pre-slug
flat files to reclaim disk on edge devices