feat: Sets the project for automatic deployment on Heroku#5
Merged
Conversation
frgfm
added
type: enhancement
frgfm
requested review from
Akilditu,
VincGargasson,
abdi-adel,
nrslt and
pechouc
nrslt
approved these changes
Oct 14, 2020
Contributor
nrslt
left a comment
nrslt
left a comment
There was a problem hiding this comment.
Hi @frgfm, thanks for the PR!
I just checked the doc for Dash deployment on Heroku and what you did seems great!
Also, nice touch with the argparse module at the end of app.py ;)
VincGargasson
approved these changes
Oct 14, 2020
Collaborator
There was a problem hiding this comment.
Interesting all the modifications to push the app on Heroku.
And good standardizations brought here for the other files. Nothing special to add.
Thanks @frgfm .
nrslt
referenced
this pull request
in nrslt/pyronear-webapp
Oct 15, 2020
feat: Sets the project for automatic deployment on Heroku (#5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at setting up all the required components for deployment on Heroku:
In order to test this, I triggered a manual deploy on the
heroku-setupbranch (automatic is set up on the master branch). Consequently, the app is already deployed and working:Any feedback is welcome!