-
Notifications
You must be signed in to change notification settings - Fork 138
VictoriaMetrics Support (VMRule) #1472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks! It needs rebase.
Did you actually try the generated rules with VictoriaMetrics? It would be great to do that. |
Yes, I did, and it worked fine. The VictoriaMetrics Docs state:
I'll look into it! |
cd12fce to
2d3d352
Compare
|
When running Pyrra with VictoriaMetrics, we saw bizarre behaviour in the generic rules. This seems to be related to the recording rule chaining and to this issue. Adding the However, I'm a bit unsure about doing the This should not be needed for the other groups, as they do not depend on each other. |
…ctoriametrics-support # Conflicts: # go.mod
|
Since there was no progress on this one for a long time, and we switched over to use sloth, I'm closing this PR. |
This PR enables the capability of setting
--victoria-metrics-mode=trueso that pyrra generates VMRules instead of PrometheusRules or ConfigMaps.As far as I know, VictoriaMetrics understands the same query language as Prometheus, so I use the same rule generation logic and just change the metadata so that VictoriaMetrics understands them.