Skip to content

bug: spotlessCheck fails on ThemePickerDialog.kt — main CI red since #87 #113

@ilmoniemi

Description

@ilmoniemi

Problem

./gradlew check (and therefore ./gradlew spotlessCheck) fails on main. Top-level CI workflow (.github/workflows/ci.yml) runs ./gradlew check assembleDebug, so every push to main since #111 has been failing.

Reproduction

git checkout main
./gradlew spotlessCheck

Output:

Execution failed for task ':spotlessKotlinCheck'.
> The following files had format violations:
      app/src/main/java/de/pyryco/mobile/ui/settings/ThemePickerDialog.kt
          @@ -48,8 +48,7 @@
           ····································selected·=·isSelected,
           ····································role·=·Role.RadioButton,
           ····································onClick·=·{·pending·=·mode·},
          -································)
          -································.padding(vertical·=·8.dp),
          +································).padding(vertical·=·8.dp),

Expected vs actual

  • Expected: ./gradlew check is green on main.
  • Actual: Spotless wants the .padding(...) chain collapsed onto the same line as the closing ) of .selectable(...). Either fix the formatting (run ./gradlew spotlessApply) or relax the rule.

Where the bug lives

app/src/main/java/de/pyryco/mobile/ui/settings/ThemePickerDialog.kt:47-52 — introduced by commit db9f2460 (PR #87, "feat(ui): Settings theme picker dialog").

CI evidence: runs 25845275106 (#111 merge, first failure) and 25845680892 (#112 merge, still failing) on .github/workflows/ci.yml.

How surfaced

Surfaced while implementing #80 (Splash Screen API plumbing). ./gradlew spotlessCheck failed in the developer agent's verification step on a file untouched by the splash work; git blame confirmed the violation predates the splash branch. Out of scope for #80 per the scope-discipline rule.

Suggested fix (one-liner)

./gradlew :spotlessApply collapses lines 51-52 to ).padding(vertical = 8.dp), and ktlint is happy. No semantic change — pure formatting.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions