ci: GitHub Actions workflow running check + assembleDebug#108
Merged
Conversation
Adds .github/workflows/ci.yml so the deterministic style / lint / build / test gates are enforced by CI rather than the developer agent's self-run. Pinned to JDK 21 (Temurin) to match gradle-daemon-jvm.properties (toolchainVersion=21); this resolves the spec's JDK 17 vs 21 open question. Concurrency cancels in-progress runs only for pull_request refs so merged commits on main always complete. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
Code Review: #85Decision: PASS Findings
SummarySmall, surgical CI workflow that matches the spec faithfully. Notable strengths:
All five acceptance criteria met, spec deviations are justified, no out-of-scope churn. Ship it. |
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlrunning./gradlew check assembleDebugon every PR and push tomain.gradle/gradle-daemon-jvm.properties(toolchainVersion=21) — this resolves the spec's JDK 17 vs 21 open question deterministically. JDK 17 would force foojay to provision a 21 toolchain on every run.pull_requestrefs (cancel-in-progress: ${{ github.event_name == 'pull_request' }}) so merged commits onmainalways complete.permissions: contents: readfor least-privilege.pull_request(NOTpull_request_target) so fork PRs cannot access secrets.Closes #85
Architecture compliance
Follows
docs/specs/architecture/85-ci-workflow.md:ubuntu-latestactions/checkout@v4→gradle/actions/wrapper-validation@v4→actions/setup-java@v4→gradle/actions/setup-gradle@v4→./gradlew check assembleDebugconnectedAndroidTest, no artifact upload, no branch protection (all explicitly out of scope)Only deviation from the spec: JDK 21 instead of the spec's default-to-17 recommendation. The spec flagged this as an open question;
gradle/gradle-daemon-jvm.propertiespins the daemon to Java 21, so JDK 21 on the runner is the correct choice.Testing
./gradlew spotlessCheck— passes (the new YAML is covered by Spotless'smiscformatter)../gradlew check assembleDebug— passes locally (18s, BUILD SUCCESSFUL). One pre-existing Compose deprecation warning inDiscussionListScreen.kt:165is unrelated to this ticket.Test plan
check assembleDebugstep passespull_request, notpull_request_target)./gradlew spotlessCheck(already verified locally)🤖 Generated with Claude Code