Conversation
Contributor
Author
Code Review: #7Decision: PASS Findings
AC verification
SummaryClean stateless Composable matching the spec layout tree. All theme tokens routed through |
First documentation pass for the project. Sets up docs/knowledge/ with INDEX.md, codebase/README.md (per-ticket file convention), feature doc for the Welcome screen, and ticket-7 implementation notes. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
WelcomeScreen— a pure stateless Composable inui/onboarding/matching the Figma6:32412×892 baseline. Hero section (colored circular logo placeholder, title, subtitle), filled primary CTAI already have pyrycodeinvokingonPaired, outlined secondary CTASet up pyrycode firstinvokingonSetup, and an open-source footer line. All colors and typography come exclusively fromMaterialTheme.colorScheme.*/MaterialTheme.typography.*. Two@Previewcomposables (light + dark,widthDp = 412,heightDp = 892) wrapped inPyrycodeMobileTheme.Per the architect's preferred option, the logo placeholder is a plain colored
Box(no inner icon) — keeps the file dependency-free and stays out-of-scope of branding.Issue
Closes #7
Testing
./gradlew assembleDebug— passes ✅./gradlew test— passes ✅ (no new unit tests; AC requires Previews + assembleDebug only, per architect spec)./gradlew lint— clean ✅./gradlew connectedAndroidTest— not run (no device/emulator attached in this env; ticket has no instrumented-test requirement)grep -E 'NavController|androidx\.navigation' app/src/main/java/de/pyryco/mobile/ui/onboarding/WelcomeScreen.kt— empty (AC4)Architecture compliance
Follows the architect's spec at
docs/specs/architecture/7-welcome-screen-scaffold.md:WelcomeScreen(onPaired: () -> Unit, onSetup: () -> Unit)— nomodifierparameter added (feat(ui): set up Navigation Compose with Welcome → ChannelList placeholder #8/feat(ui): wire Welcome screen CTAs to Scanner navigation + external browser #14 don't pass one).Surface(background) > Column(fillMaxSize, systemBarsPadding, padding 24×32, SpaceBetween, CenterHorizontally)with hero (weight(1f)+ bracketingSpacer.weight(1f)for vertical centering), CTA stack, footer.material3,foundation.layout,foundation.shape.CircleShape,runtime.Composable,ui.*,unit.dp,tooling.preview.Preview, project theme — nonavigation, noactivity, noIntent.private, passdarkTheme = true/falseexplicitly for deterministic rendering.